This repository has been archived by the owner on May 12, 2021. It is now read-only.
cli: fix the issue of using wrong path to get version #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergwolf
approved these changes
Oct 30, 2018
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this pull request
Oct 30, 2018
Refactor the config related codes into a separated package which can be shared with other cli programs such as kata's shimv2. Depends-on: github.com/kata-containers#869 Fixes: kata-containers#787 Fixes: kata-containers#714 Signed-off-by: fupan <[email protected]>
|
lgtm |
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this pull request
Oct 30, 2018
Refactor the config related codes into a separated package which can be shared with other cli programs such as kata's shimv2. Fixes: kata-containers#787 Fixes: kata-containers#714 Depends-on:github.com/kata-containers#869 Signed-off-by: fupan <[email protected]>
Both of the netmon and proxy should use the right path figured out from the configure instead of the default settings to get their versions. Fixes: kata-containers#868 Signed-off-by: Fupan Li <[email protected]>
grahamwhaley
approved these changes
Oct 30, 2018
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this pull request
Oct 30, 2018
Refactor the config related codes into a separated package which can be shared with other cli programs such as kata's shimv2. Fixes: kata-containers#787 Fixes: kata-containers#714 Depends-on:github.com/kata-containers#869 Signed-off-by: fupan <[email protected]>
|
/test |
|
/retest |
sboeuf
approved these changes
Oct 30, 2018
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
This PR enables the github actions for agent repository. Fixes kata-containers#869 Signed-off-by: Gabriela Cervantes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of the netmon and proxy should use the right path
figured out from the configure instead of the default settings
to get their versions.
Fixes: #868
Signed-off-by: Fupan Li [email protected]