This repository has been archived by the owner on May 12, 2021. It is now read-only.
shim/firecracker: Read agent's logs #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodh-intel
reviewed
Oct 7, 2019
devimc
force-pushed
the
topic/logs/fcReadAgentLogs
branch
2 times, most recently
from
9d6c9be to
0a26055
Compare
|
/test @jodh-intel change applied, thanks |
added 2 commits
October 7, 2019 16:38
Add support for reading agent's logs from a hybrid vsock. This feature is very useful for debugging hypervisors that don't have a socket connected to `/dev/console`, like firecracker fixes kata-containers#209 Signed-off-by: Julio Montes <[email protected]>
bring support for logging through a hybrid vsock shortlog: 95be1c3 agent: add support for logging to a vsock port a03e23b protocols/client: improve hybrid vsock parser 6a96997 protocols/client: make schemes and hybrid vsock dialer public e01f23c network: Add a testcase for setupDNS d733185 network: Setup DNS for sandbox Signed-off-by: Julio Montes <[email protected]>
devimc
force-pushed
the
topic/logs/fcReadAgentLogs
branch
from
b8a8629 to
6aa2d82
Compare
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 37.7% 34.15% -3.55%
==========================================
Files 7 7
Lines 366 404 +38
==========================================
Hits 138 138
- Misses 215 253 +38
Partials 13 13 |
devimc
pushed a commit
to devimc/kata-runtime
that referenced
this pull request
Oct 7, 2019
In firecracker, there is no socket connected to /dev/console, so let's use a vsock port to get agent's logs Depends-on: github.com/kata-containers/shim#210 fixes kata-containers#2103 Signed-off-by: Julio Montes <[email protected]>
|
/test |
GabyCT
approved these changes
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reading agent's logs from a hybrid vsock. This feature is
very useful for debugging hypervisors that don't have a socket connected to
/dev/console, like firecrackerfixes #209
Signed-off-by: Julio Montes [email protected]