This repository has been archived by the owner on May 12, 2021. It is now read-only.
main: stacktrace/coredump on error #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboeuf
approved these changes
Mar 7, 2018
|
@jodh-intel please fix the CI failures (Travis I mean). |
If the shim fails due to an internal error or if it receives a fatal signal, write a stack trace to the log and exit. If it was started with `--debug` also dump core. Fixes kata-containers#57. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
stacktrace-on-error
branch
from
4c98f49 to
ab8eb53
Compare
|
@sboeuf - Travis is happy now ;) |
This was referenced Mar 8, 2018
|
@bergwolf PTAL |
|
lgtm |
|
Assuming Jenkins is still WiP... I'm merging it. |
This was referenced Mar 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the shim fails due to an internal error or if it receives a fatal
signal, write a stack trace to the log and exit.
If it was started with
--debugalso dump core.Fixes #57.
Signed-off-by: James O. D. Hunt [email protected]