Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

integration tests for cpuset need updating #2845

Closed
egernst opened this issue Sep 10, 2020 · 0 comments
Closed

integration tests for cpuset need updating #2845

egernst opened this issue Sep 10, 2020 · 0 comments
Assignees
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@egernst
Copy link
Member

egernst commented Sep 10, 2020

Description of problem

Integration tests currently had a couple of issues:

  • min cpu required was wrong
  • cpuset tests assume that we are setting cpusets in the guest, which isn't (shouldn't) be supported currently. cpusets are currently only managed on host. We will add guest (container specific cpuset) support soon.

Expected result

Tests don't assume cpusets are set in the guest.

Actual result

Test verifies that nproc is tied to cpuset size, which isn't necessarily the case at this time.

@egernst egernst added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Sep 10, 2020
egernst added a commit to egernst/tests that referenced this issue Sep 10, 2020
The minimum number of CPUs were wrong.

0,2 -> [0,2] = 2, not 3.

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
egernst added a commit to egernst/tests that referenced this issue Sep 10, 2020
The minimum number of CPUs were wrong.

0,2 -> [0,2] = 2, not 3.

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
@egernst egernst self-assigned this Sep 10, 2020
egernst added a commit to egernst/tests that referenced this issue Sep 10, 2020
This test will fail until we have appropriate CPUSet support inside the
guest. Today CPUSets are only supported on the host, and are done by
placing the entire guest into a CPUset that matches the sum of container
cpusets. This isn't reflected via nproc in the guest.

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
egernst added a commit to egernst/tests that referenced this issue Sep 11, 2020
This test will fail until we have appropriate CPUSet support inside the
guest. Today CPUSets are only supported on the host, and are done by
placing the entire guest into a CPUset that matches the sum of container
cpusets. This isn't reflected via nproc in the guest.

- Remove test that checked nproc
- Update cpu test to check host cpuset cgroup

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
chavafg pushed a commit to chavafg/tests-1 that referenced this issue Oct 16, 2020
The minimum number of CPUs were wrong.

sum of cpus in set 0,2 is 2, not 3.
sum of cpus in set 0,3 is 2, not 3.

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
(cherry picked from commit 2ef790b)
chavafg pushed a commit to chavafg/tests-1 that referenced this issue Oct 16, 2020
This test will fail until we have appropriate CPUSet support inside the
guest. Today CPUSets are only supported on the host, and are done by
placing the entire guest into a CPUset that matches the sum of container
cpusets. This isn't reflected via nproc in the guest.

- Remove test that checked nproc
- Update cpu test to check host cpuset cgroup

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
(cherry picked from commit d0b76d1)
chavafg pushed a commit to chavafg/tests-1 that referenced this issue Oct 16, 2020
The minimum number of CPUs were wrong.

sum of cpus in set 0,2 is 2, not 3.
sum of cpus in set 0,3 is 2, not 3.

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
(cherry picked from commit 2ef790b)
chavafg pushed a commit to chavafg/tests-1 that referenced this issue Oct 16, 2020
This test will fail until we have appropriate CPUSet support inside the
guest. Today CPUSets are only supported on the host, and are done by
placing the entire guest into a CPUset that matches the sum of container
cpusets. This isn't reflected via nproc in the guest.

- Remove test that checked nproc
- Update cpu test to check host cpuset cgroup

Fixes: kata-containers#2845

Signed-off-by: Eric Ernst <[email protected]>
(cherry picked from commit d0b76d1)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

No branches or pull requests

1 participant