Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Memory Hotplug is not available on arm64 #879

Closed
Pennyzct opened this issue Nov 1, 2018 · 2 comments
Closed

Memory Hotplug is not available on arm64 #879

Pennyzct opened this issue Nov 1, 2018 · 2 comments

Comments

@Pennyzct
Copy link
Contributor

Pennyzct commented Nov 1, 2018

Description of problem

Looking into the implementation of new feature: memory hotplug, runtime/#400, it uses the (qemu) device_add pc-dimm,id=dimm1,memdev=mem1 to limit memory on runtime. However, this feature is not availble for arm64 for now.

Actual result

Nov 01 10:53:19 entos-thunderx2-desktop kata-runtime[184060]: time="2018-11-01T10:53:19.183208764+08:00" level=info msg="{\"error\": {\"class\": \"GenericError\", \"desc\": \"'pc-dimm' is not a valid device model name\"}}" arch=arm64 command=create container=aee45652f4df987389e82774b94a2da9fd702356e37559761a7dedc7bb60ff79 name=kata-runtime pid=184060 source=virtcontainers subsystem=qmp

This will lead to a large portion of mem_test.go failed. I will configure the filter configuration to skip these tests asap.
@Weichen81

@Pennyzct
Copy link
Contributor Author

Pennyzct commented Nov 1, 2018

That also means that -m option for memory limit in docker commands is not workable on arm64 when runtime is kata-runtime.

Pennyzct added a commit to Pennyzct/tests that referenced this issue Nov 2, 2018
Since the new feature: memory hotplug, which uses the " (qemu)
device_add pc-dimm,id=dimm1,memdev=mem1 " to limit memory on runtime,
is not availble on arm platform, for now we just have to resort to
skip relevant tests in aarch64.

Fixes: kata-containers#879

Signed-off-by: Penny Zheng [email protected]
@jodh-intel
Copy link
Contributor

That also means that -m option for memory limit in docker commands is not workable on arm64 when runtime is kata-runtime.

It would probably be worth capturing that in:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants