This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
ci: Fixes to build experimental QEMU with virtiofs #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this pull request
Jul 23, 2020
Update to qemu 5.0.x with support for virtiofs + dax. Depends-on: github.com/kata-containers/packaging#1097 Depends-on: github.com/kata-containers/tests#2737 Fixes: kata-containers#2848 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
|
/test-virtiofs |
jcvenegas
force-pushed
the
qemu-virtiofs-vmx-rdseed-exit
branch
from
84c97d1 to
26b3432
Compare
|
/test |
jcvenegas
added a commit
to jcvenegas/kata-packaging
that referenced
this pull request
Jul 23, 2020
Update build scripts for qemu-virtiofs Depends-on: github.com/kata-containers/runtime#2840 Depends-on: github.com/kata-containers/tests#2737 Fixes: github.com/kata-containers/runtime#2848 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
amshinde
reviewed
Jul 27, 2020
.ci/install_runtime.sh
Outdated
| fi | ||
| fi | ||
| if [ "$CI" == true ] && [ "$(uname -m)" == "x86_64" ]; then | ||
| qemu_version="$(get_version "assets.hypervisor.qemu.version")" |
There was a problem hiding this comment.
@jcvenegas Is this just a placeholder change for testing CI for the change you are working on for virtiofs-qemu?
Because, here you are fetching version of qemu and not experimental/virtiofs qemu.
jcvenegas
changed the title
Experimental QEMU will be updated to qemu 5.0, not needed to check for qemu version and disable in all the time. Depends-on: github.com/kata-containers/packaging#1097 Depends-on: github.com/kata-containers/runtime#2840 Fixes: kata-containers#2736 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas
force-pushed
the
qemu-virtiofs-vmx-rdseed-exit
branch
2 times, most recently
from
f4309c0 to
c7545b3
Compare
On upgrade for qemu 5.0 + virtiofs, the virtiofsd daemon virtiofsd forks itself so, smem sees the process two times, the JSON creation failed to build a valid JSON file because two times the number of expected virtiofs values were added, this fix by calculating the PSS usage of virtiofsd, this is the sum of the two virtiofsd process seen by smem. Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas
force-pushed
the
qemu-virtiofs-vmx-rdseed-exit
branch
from
ed3558e to
0f26e2f
Compare
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this pull request
Aug 11, 2020
Update to qemu 5.0.x with support for virtiofs + dax. Depends-on: github.com/kata-containers/packaging#1097 Depends-on: github.com/kata-containers/tests#2737 Fixes: kata-containers#2848 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas
added a commit
to jcvenegas/kata-packaging
that referenced
this pull request
Aug 12, 2020
Update build scripts for qemu-virtiofs Depends-on: github.com/kata-containers/runtime#2840 Depends-on: github.com/kata-containers/tests#2737 Fixes: github.com/kata-containers/runtime#2848 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas
added a commit
to jcvenegas/kata-packaging
that referenced
this pull request
Aug 12, 2020
Update build scripts for qemu-virtiofs Depends-on: github.com/kata-containers/runtime#2840 Depends-on: github.com/kata-containers/tests#2737 Fixes: github.com/kata-containers/runtime#2848 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas
added a commit
to jcvenegas/kata-packaging
that referenced
this pull request
Aug 12, 2020
Update build scripts for qemu-virtiofs. - virtiofs-0.3 patches are not needed - Sync build on how vanilla qemu is built - Apply patches for virtiofsd if any (none today) - Apply patches that are used for the qemu vanilla - Apply patches in order Depends-on: github.com/kata-containers/runtime#2840 Depends-on: github.com/kata-containers/tests#2737 Fixes: github.com/kata-containers/runtime#2848 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
|
/test |
1 similar comment
|
/test |
|
This PR is required as the dependent PR of kata-containers/runtime#2840. PTAL. @amshinde @GabyCT @jcvenegas I assume there is no blockers to merge this PR. Please correct me if I am wrong. |
jcvenegas
changed the title
|
@likebreath yes, this should be merged now that the other PR was merge, this needs some ack to get it merged |
GabyCT
reviewed
Aug 14, 2020
| # memory of virtiofsd. | ||
| # It is a special case of get_pss_memory, | ||
| # virtiofsd forks itself so, smem sees the process | ||
| # two times, this function sum both pss values: |
GabyCT
approved these changes
Aug 14, 2020
likebreath
approved these changes
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-on: github.com/kata-containers/packaging#1097
Depends-on: github.com/kata-containers/runtime#2840
Fixes: #2736
Signed-off-by: Jose Carlos Venegas Munoz [email protected]