This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
integration/docker:modify test of memory hotplug when create container #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look and trigger the CI. |
|
/test |
|
lgtm |
linzichang
added a commit
to linzichang/runtime
that referenced
this pull request
Oct 15, 2018
When create sandbox, we setup a sandbox of 2048M base memory, and then hotplug memory that is needed for every new container. And we change the unit of c.config.Resources.Mem from MiB to Byte in order to prevent the 4095B < memory < 1MiB from being lost. Depends-on:github.com/kata-containers/tests#813 Fixes kata-containers#400 Signed-off-by: Clare Chen <[email protected]> Signed-off-by: Zichang Lin <[email protected]>
|
/retest |
Modify test of memory hotplug when create container. Depends-on:github.com/kata-containers/runtime#786 Fixes #812 Signed-off-by: Clare Chen <[email protected]>
|
@bergwolf @jodh-intel @jcvenegas Please take a look. |
|
/test |
|
lgtm |
|
Hi @jodh-intel Could you please help me rebuild the failed CI? As I have no authority, thanks~ |
|
Hi @clarecch - I've restarted them again, but I suspect they are going to fail again... We've had a problem recently where for reasons I don't understand a high proportion of the jobs have been scheduled on systems that do not support nested kvm. This is a recent change and currently causes all tests to fail. I believe that @mnaser is investigating. |
|
lgtm |
jcvenegas
approved these changes
Oct 17, 2018
|
Ignoring known metrics CI fail - merging. |
|
Thanks @grahamwhaley |
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Nov 22, 2018
When create sandbox, we setup a sandbox of 2048M base memory, and then hotplug memory that is needed for every new container. And we change the unit of c.config.Resources.Mem from MiB to Byte in order to prevent the 4095B < memory < 1MiB from being lost. Depends-on:github.com/kata-containers/tests#813 Fixes kata-containers#400 Signed-off-by: Clare Chen <[email protected]> Signed-off-by: Zichang Lin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify test of memory hotplug when create container.
Depends-on:github.com/kata-containers/runtime#786
Fixes #812
Signed-off-by: Clare Chen [email protected]