This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Update ci and tests scripts for kubernetes 1.12 #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
chavafg
force-pushed
the
topic/changes-k8s-1.12
branch
5 times, most recently
from
65c00ed to
2d9f46a
Compare
jodh-intel
reviewed
Nov 22, 2018
| @@ -5,7 +5,9 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| # | |||
|
|
|||
| set -e | |||
| set -o errexit | |||
| set -o nounset | |||
| # This instruction will wait until it is up and running, so we can | ||
| # start creating our containers. | ||
| dns_wait_time=300 | ||
| dns_wait_time=120 |
There was a problem hiding this comment.
I'm not really clear on this change - if it takes ~2 minutes to start, why are we reducing the time we wait in case it takes a little longer?
There was a problem hiding this comment.
well, it is actually taking less than 2 minutes, so I wanted to try reducing the time from 300s. So far it has been working well with the 2 minutes timeout.
|
lgtm |
chavafg
force-pushed
the
topic/changes-k8s-1.12
branch
from
3b88660 to
7a20e0a
Compare
|
/test |
chavafg
added a commit
to chavafg/runtime-1
that referenced
this pull request
Nov 22, 2018
Update supported versions of Kubernetes with its corresponding CRI implementations: - Kubernetes from 1.10.5 to 1.12.2 - cri-o from 1.10 to 1.12.0, commit: fa540c8e806d28c2cbcd157bdf8acf2b20990ab6 as it is needed for fixing the devicemapper issues when removing a pod. More info on this issue, see: cri-o/cri-o#1883 - containerd from 1.1.3 to 1.2.0 Fixes: kata-containers#927. Depends-on: github.com/kata-containers/tests#926 Signed-off-by: Salvador Fuentes <[email protected]>
crio.conf has changed its format in the 1.12 version. Change our scripts to match this new format. Signed-off-by: Salvador Fuentes <[email protected]>
Update init and cleanup scripts. - Use updated flannel config file, taken from the documentation documents, which is now downloaded from the coreos/flannel repository. - Use a yaml configuration file to initialize kubeadm. - Remove workaround to delete pods after the kubeadm reset. Fixes: kata-containers#925. Fixes: kata-containers#296. Signed-off-by: Salvador Fuentes <[email protected]>
Add untrusted annotation tags to the pod configuration files and use the `kubectl wait` instead of our `waitForProcess` script to know if a pod is running. Depends-on: github.com/kata-containers/runtime#928 Signed-off-by: Salvador Fuentes <[email protected]>
The tests that verify the uts and ipc namespaces and the CPU test using containerd work well on k8s 1.12. Fixes: kata-containers#793. Fixes: kata-containers#794. Signed-off-by: Salvador Fuentes <[email protected]>
chavafg
force-pushed
the
topic/changes-k8s-1.12
branch
2 times, most recently
from
a126b65 to
18c593d
Compare
|
/test |
Remove kubernetes packages and configuration when running on baremetal machines. Signed-off-by: Salvador Fuentes <[email protected]>
chavafg
force-pushed
the
topic/changes-k8s-1.12
branch
from
18c593d to
4ff6bc6
Compare
|
/test |
|
Nice! Thanks @chavafg ! LGTM |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
kubectl wait