Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registry auth credentials to be set from environment variable #903

Closed
josh-ferrell opened this issue Mar 16, 2022 · 1 comment
Closed

Allow registry auth credentials to be set from environment variable #903

josh-ferrell opened this issue Mar 16, 2022 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@josh-ferrell
Copy link

josh-ferrell commented Mar 16, 2022 •
edited
Loading

What would you like to be added:

The ability to input the AUTH_STRING or credentials for crictl pull using an environment variable.

Why is this needed:

The ability to supply credentials when crictl is being called by another process programmatically.
@josh-ferrell josh-ferrell added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 16, 2022
@saschagrunert
Copy link
Member

saschagrunert commented Mar 17, 2022 •
edited
Loading

Hey @josh-ferrell this seems to be a good idea and should be straightforward to implement. Are you planning to work on this?

Edit: Now I saw #904

@saschagrunert saschagrunert mentioned this issue Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saschagrunert @josh-ferrell