Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRICTL_AUTH/CRICTL_CREDS env var option to crictl pull #904

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Add CRICTL_AUTH/CRICTL_CREDS env var option to crictl pull #904

merged 1 commit into from
Mar 17, 2022

Conversation

josh-ferrell
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds the ability to input the AUTH_STRING for crictl pull using an environment variable. This provides the ability to supply credentials when crictl is being called by another process programmatically.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes

Add the ability to provide the registry authentication string using the CRICTL_AUTH or the credentials using the CRICTL_CREDS environment variables.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022
@saschagrunert saschagrunert mentioned this pull request Mar 17, 2022
Closed
saschagrunert
saschagrunert approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josh-ferrell, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@saschagrunert
Copy link
Member

Closes #903

@saschagrunert
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit a567ea8 into kubernetes-sigs:master Mar 17, 2022
@josh-ferrell josh-ferrell mentioned this pull request Mar 17, 2022
Closed
@thomasmey thomasmey mentioned this pull request Apr 14, 2022
Closed
@josh-ferrell josh-ferrell mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh-ferrell @k8s-ci-robot @saschagrunert