Migrate to field based seccomp tests #1181
Conversation
The seccomp profile path field is deprecated since many releases within Kubernetes, where CRI API consumers should use the native field. We now migrate the tests to use them. Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
kind/api-change
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
|
||
| By("create seccomp sandbox and container") | ||
| podID, containerID = seccompTestContainer(rc, ic, seccompProfile) | ||
|
|
||
| By("verify seccomp profile") | ||
| verifySeccomp(rc, containerID, []string{"grep", "ecc", "/proc/self/status"}, false, "1") // seccomp enabled |
There was a problem hiding this comment.
Trying to update cri-tools to 1.27.1 in containerd, the containerd CI fails (containerd/containerd#8937 (comment) / https://github.com/containerd/containerd/actions/runs/5802001382/job/15727585673?pr=8937#step:9:197)
default: [FAILED] Expected
default: <string>: Seccomp: 2
default:
default: to contain substring
default: <string>: 1
I have no idea if this test need to be improved or something weird is happening in containerd CI
There was a problem hiding this comment.
Yes, this needs adoption. See: #1236
What type of PR is this?
/kind api-change
What this PR does / why we need it:
The seccomp profile path field is deprecated since many releases within Kubernetes, where CRI API consumers should use the native field.
We now migrate the tests to use them.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Refers to cri-o/cri-o#7006
Does this PR introduce a user-facing change?