Add crictl config e2e tests
#1659
Conversation
Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| Expect(cfg).To(MatchRegexp("timeout .* 10")) | ||
| }) | ||
|
|
||
| It("should succeed to set config values and preserve comments", func() { |
There was a problem hiding this comment.
I wonder how it will treat duplicate entries.
There was a problem hiding this comment.
It will only change the first one, which is a bug. Going to fix that in #1661
| Expect(cfg).To(MatchRegexp("timeout .* 10")) | ||
| }) | ||
|
|
||
| It("should succeed to set config values and preserve comments", func() { |
There was a problem hiding this comment.
I don't know if preserving comments is a valuable feature. But I can see how it may be useful and some people relying on it, thank you for adding a test!
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adding e2e tests for the config get / set.
Which issue(s) this PR fixes:
Follow-up on #1643
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?