Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cgroup v1 support into maintenance mode #4569

Closed
8 tasks done
harche opened this issue Apr 4, 2024 · 35 comments
Closed
8 tasks done

Move cgroup v1 support into maintenance mode #4569

harche opened this issue Apr 4, 2024 · 35 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team

Comments

@harche
Copy link
Contributor

harche commented Apr 4, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 4, 2024
@harche
Copy link
Contributor Author

harche commented Apr 4, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 4, 2024
@harche
Copy link
Contributor Author

harche commented Apr 4, 2024

/assign

@SergeyKanzhelev SergeyKanzhelev changed the title Deprecate support for cgroup v1 Moving cgroup v1 support into maintenance mode Apr 16, 2024
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Apr 16, 2024

I updated the name of a KEP (this issue title) as per our decision: #4572 (comment).

@harche can you please update it in kep.yaml as well?

@SergeyKanzhelev SergeyKanzhelev changed the title Moving cgroup v1 support into maintenance mode Move cgroup v1 support into maintenance mode Apr 17, 2024
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 23, 2024
@tjons
Copy link
Contributor

tjons commented Jun 5, 2024

Hello @harche 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage stable for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@tjons tjons moved this to Tracked for Enhancements Freeze in 1.31 Enhancements Tracking Jun 5, 2024
@sreeram-venkitesh
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 5, 2024
@harche
Copy link
Contributor Author

harche commented Jun 5, 2024

@sreeram-venkitesh this feature is going straight for GA. There is no alpha or beta stage for this feature.

@sreeram-venkitesh
Copy link
Member

@harche Thanks for clarifying! Would you consider this KEP as of type Deprecation? (See Type column in the enhancements tracking board) Does maintenance mode entail that the feature/KEP is planned to be deprecated? Please also update the issue description.

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 5, 2024
@harche
Copy link
Contributor Author

harche commented Jun 5, 2024

Thanks for clarifying! Would you consider this KEP as of type Deprecation?

This KEP is not going to deprecate cgroup v1 support, hence we would not like to classify it as deprecation.

@sreeram-venkitesh
Copy link
Member

Thanks for the quick update!

@hacktivist123
Copy link

Hello @harche 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

@harche
Copy link
Contributor Author

harche commented Jun 12, 2024

Hello @harche 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

kubernetes/website#46801

@rashansmith
Copy link

Hi @harche,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@tjons
Copy link
Contributor

tjons commented Sep 15, 2024

Hello 👋 1.32 Enhancements Lead here,

I'm closing milestone 1.31 now,
If you have more work on this enhancement to complete in v1.32, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.32. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Sep 15, 2024
@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2025
@kannon92
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2025
@kannon92
Copy link
Contributor

kannon92 commented Jan 20, 2025

@harche anything left to do for this feature?

There is no feature gate so can we close this as done?

@harche
Copy link
Contributor Author

harche commented Jan 20, 2025

@harche anything left to do for this feature?

There is no feature gate so can we close this as done?

All PRs for this feature have been merged.

/close

@k8s-ci-robot
Copy link
Contributor

@harche: Closing this issue.

In response to this:

@harche anything left to do for this feature?

There is no feature gate so can we close this as done?

All PRs for this feature have been merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
No open projects
Status: Tracked for Doc Freeze
Status: Done
Development

No branches or pull requests

10 participants