Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure cilium hubble prometheus scraping and cilium metric filtering #3202

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

huntergregory
Copy link

@huntergregory huntergregory commented Feb 21, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

ClusterLoader2 already supports scraping Prometheus metrics from the Cilium agent.

This PR appends a scrape target for Cilium's Hubble metric endpoint. One can enable either agent metric scraping, hubble metric scraping, or both.

This PR also introduces support for specifying the metric keep list for filtering agent or hubble metrics.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huntergregory
Once this PR has been reviewed and has the lgtm label, please assign mborsz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2025
@huntergregory huntergregory changed the title feat: configure cilium hubble prometheus scraping feat: configure cilium hubble prometheus scraping and cilium metric keep lists Feb 21, 2025
@huntergregory huntergregory changed the title feat: configure cilium hubble prometheus scraping and cilium metric keep lists feat: configure cilium hubble prometheus scraping and cilium metric filtering Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants