Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push-build: Support pushing cross builds to a /cross subdirectory #1386

Merged
merged 2 commits into from
Jul 2, 2020
Merged

push-build: Support pushing cross builds to a /cross subdirectory #1386

merged 2 commits into from
Jul 2, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind feature cleanup
/priority critical-urgent

What this PR does / why we need it:

  • push-build: Support pushing cross builds to a /cross subdirectory
  • lib/release: Remove unused build_type from local staging function

Follow-up to #1385.

/assign @tpepper @hasheddan @saschagrunert @cpanato
cc: @kubernetes/release-engineering @BenTheElder @spiffxp
ref: kubernetes/sig-release#850, kubernetes/sig-release#759

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I'll come back with more details shortly; just getting the PR up in the meantime.

Does this PR introduce a user-facing change?

push-build: Support pushing cross builds to a /cross subdirectory

@justaugustus
lib/release: Remove unused build_type from local staging function
547f755 
build_type is used as an option but not plumbed to any logic in
release::gcs::locally_stage_release_artifacts, so we remove it here.

Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus
push-build: Support pushing cross builds to a /cross subdirectory
218536a 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2020
@justaugustus justaugustus mentioned this pull request Jul 2, 2020
Closed
hasheddan
hasheddan approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit a4d4b5b into kubernetes:master Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 2, 2020
This was referenced Jul 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@idealhack idealhack Awaiting requested review from idealhack

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@saschagrunert saschagrunert

@tpepper tpepper

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @hasheddan @saschagrunert @tpepper @cpanato