-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git.RemoteTags() function #1625
Conversation
ff75f8d
to
238cd94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
for rebase
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
238cd94
to
c34f3d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/test pull-release-integration-test |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a new function to the git package:
git.RemoteTags()
which queries the default remote repository and returns it's tags in a string slice.It also modifies the
git.LsRemote()
function so that it honorsRepo.maxRetries
when performing the remote query.Which issue(s) this PR fixes:
Related to #1595
Special notes for your reviewer:
Depends on #1621 to run
Does this PR introduce a user-facing change?