Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/cip: Use --no-dry-run instead of --dry-run #1806

Merged
merged 1 commit into from
Nov 30, 2020
Merged

pkg/cip: Use --no-dry-run instead of --dry-run #1806

merged 1 commit into from
Nov 30, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Nov 30, 2020 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Similar to our --nomock flags for other tools, we should use a
--no-dry-run for cip, since the default nil value for booleans is
false.

Meaning: If --dry-run is not explicitly set to true, our tooling will
initiate an image promotion.

Signed-off-by: Stephen Augustus [email protected]

/assign @hasheddan @xmudrii
cc: @kubernetes/release-engineering
/priority critical-urgent

Caught in https://kubernetes.slack.com/archives/C2C40FMNF/p1606776666277400?thread_ts=1606741064.265000&cid=C2C40FMNF.
Nice eye, Marko!

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- pkg/cip: Use --no-dry-run instead of --dry-run

  Similar to our `--nomock` flags for other tools, we should use a
  `--no-dry-run` for `cip`, since the default nil value for booleans is
  `false`.

  Meaning: If `--dry-run` is not explicitly set to `true`, our tooling will
  initiate an image promotion.

@justaugustus
pkg/cip: Use --no-dry-run instead of --dry-run
7b1dd7e 
Similar to our `--nomock` flags for other tools, we should use a
`--no-dry-run` for `cip`, since the default nil value for booleans is
`false`.

Meaning: If `--dry-run` is not explicitly set to `true`, our tooling will
initiate an image promotion.

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 30, 2020
hasheddan
hasheddan approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2020
xmudrii
xmudrii approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xmudrii
xmudrii reviewed Nov 30, 2020
View reviewed changes
pkg/cip/cli/run.go
@@ -159,8 +159,9 @@ func RunPromoteCmd(opts *RunOptions) error {
sc, err = reg.MakeSyncContext(
mfests,
opts.Threads,
opts.DryRun,
opts.UseServiceAcct)
opts.NoDryRun,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure what does that function expects, but if it takes dryRun, shouldn’t we also invert it here?

For example, if takes dryRun and it is dryRun, noDryRun would be set to false, so this function would run as noDryRun instead of dryRun.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmudrii -- It's inverted below, starting with https://github.com/kubernetes/release/pull/1806/files#diff-94fc64f6c6f758dcf8d71f20a75b9e43e7093ec5eb51c2ca80ad45532a31b423R62.

@k8s-ci-robot k8s-ci-robot merged commit 32f6156 into kubernetes:master Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@hasheddan hasheddan hasheddan approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@listx listx Awaiting requested review from listx

Assignees

@xmudrii xmudrii

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @k8s-ci-robot @xmudrii @hasheddan