-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BuildVersion verification and local checks in krel build #2024
Conversation
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
/milestone v1.22 |
/priority important-soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
This PR improves the input validation in
krel release
by introducing the following changes:release.IsValidReleaseBuild()
function now enforces theversionBuildRE
regexp to check the build version when it contains a plus sign.krel release
will now perform a local validation of the options before running.While the options are checked during the release process, double-checking them saves the release manager time in case of an error and resources by avoiding the execution of a job destined to fail.
Which issue(s) this PR fixes:
Stops a recurring problem with input encountered again during the
v1.22.0-alpha.1
cut (kubernetes/sig-release#1547)Special notes for your reviewer:
Does this PR introduce a user-facing change?