Desktop,Mobile: Sync: Fix share not marked as readonly if the recipient has an outgoing share #11770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s an outgoing share The client would allow the user to write to the share, which would then result in conflicts on sync
Comment on lines
-95
to
+96
| if (shareState.shares.find(s => s.user.id === userId)) return false; | ||
| const parentShare = shareState.shares.find(s => s.id === item.share_id); | ||
| if (parentShare && parentShare.user?.id === userId) return false; |
There was a problem hiding this comment.
Previously,
if (shareState.shares.find(s => s.user.id === userId)) return false;
would always return if userId was the owner of a share, regardless of whether the share is the parent of the item under consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Suppose user A has an outgoing share, but then accepts an incoming read-only share from user B. Prior to this pull request, the share from user B would be marked as writable by Joplin clients. However, all changes user A makes to the share from user B will result in conflicts (because the share is actually read-only).
This pull request updates the read-only logic to handle the case where a recipient of a share is the owner of a different share.
Testing plan