Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make local extension files writable during zip creation #242256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CertainLach
Copy link

Fixes: #151543

path: `extension/${path.relative(extension.location.fsPath, localPath)}`,
localPath,
// chmod u+w,g+w
mode: stat.mode | 0o220,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u+w (0o200) should be enough here, not sure if group permissions matter, added just in case.
It is also possible to change mode during extension unpack phase, but I didn't want to alter behavior for users whose extension directory is not immutable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read-only --extensions-dir break remote extension installation
3 participants