verifier: do not run invalid platforms check when there are no results #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Feb 12, 2025
When `--call=lint` or `--call=outline` were used, the intention wasn't to run this check because the result doesn't have a platform. When those checks are run, there is no exporter platforms key. We would check `Request` from the request operations, but this wasn't a reliable way to determine whether the result was from a lint because it is possible for subrequests to have different frontend attributes than the primary request and the primary request would sometimes not have the `requestid` attribute set. Instead of detecting a subrequest with that method, the check has been updated to exit if there are no references and if there is no exporter key. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
fix-check-invalid-platforms
branch
from
01a3b46 to
14d407b
Compare
|
Added an integration test. |
tonistiigi
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--call=lintor--call=outlinewere used, the intention wasn't to run this check because the result doesn't have a platform. When those checks are run, there is no exporter platforms key.We would check
Requestfrom the request operations, but this wasn't a reliable way to determine whether the result was from a lint because it is possible for subrequests to have different frontend attributes than the primary request and the primary request would sometimes not have therequestidattribute set.Instead of detecting a subrequest with that method, the check has been updated to exit if there are no references and if there is no exporter key.
Fixes #5693.