kvm/qemu mounting #598
Merged
kvm/qemu mounting #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaudinho
force-pushed
the
kvm/qemu-mounting
branch
from
f9e603d to
ef536ff
Compare
eyberg
reviewed
Sep 3, 2020
`ops volume attach` lets user attach volume to a stopped instance. as of this commit, `ops run` overwrite this config though. `ops run --mounts` lets user mount volume to an instance on run, but does not persist the config. as of this commit, changes made to volume during run is visible, but gets discarded on subsequent run without `--skipbuild`
ronaudinho
force-pushed
the
kvm/qemu-mounting
branch
from
ef536ff to
c38b78d
Compare
eyberg
reviewed
Sep 21, 2020
|
|
||
| // saveImageConfig saves image config as JSON | ||
| // for volume attach/detach purposes | ||
| func saveImageConfig(c Config) error { |
There was a problem hiding this comment.
this is fine for now but something we should prob. fix in the future - a good chunk of the variables being stored here are dynamic in nature and don't belong here;
also - 'manifests' have an inherent meaning already and probably wise to change this to a different phrase
eyberg
approved these changes
Sep 21, 2020
lepton/manifest.go
Outdated
| } | ||
|
|
||
| var vmpath string | ||
| if hostpath[0] != '/' { |
|
merging since original comments were fixed && i've created tkts for the other issues and this has been sitting for a few weeks now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC
JSONstore to keep track of created volumes, maybe use some more established KV store?ops volume createto create volume is necessary before runningops run --mounts <uuid:mount_path>sinceUUIDis necessary. my idea is that when user wants to mount on run, they could perhaps just providehost_pathand that new volume will be created and attached on the fly?sample usage can be seen at ronaudinho/ops-examples@722fff5
(i tested
JSONread/write, but on write,json.Unmarshalresult is weird, so i do not call it in the main)references
TODO