-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): svelte 5 compatibility updates #12634
base: main
Are you sure you want to change the base?
Conversation
Fixup previous reference to next-auth
Update code for svelte 5
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@nicolecomputer is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change requested, but otherwise looks good for Svelte 5 compat 🙏
@@ -55,7 +55,7 @@ import { | |||
} from "drizzle-orm/pg-core" | |||
import postgres from "postgres" | |||
import { drizzle } from "drizzle-orm/postgres-js" | |||
import type { AdapterAccountType } from "next-auth/adapters" | |||
import type { AdapterAccountType } from "@auth/core/adapters"; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should never have to install / interact with @auth/core
as a consumer of these libraries.
Could you not get the AdapterAccountType
type from @auth/sveltekit/adapters
? If not, then that's a bug that should be fixed - let me know 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it's not there. Here's the error message: Cannot find module '@auth/sveltekit/adapters' or its corresponding type declarations.ts(2307)
From my package.json:
"@auth/sveltekit": "^1.7.4",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed this as a bug: #12649
☕️ Reasoning
These were changes I needed to make while working through the docs with a new Svelte 5 app.
🧢 Checklist