[Bindings/Odin] Update Odin bindings to latest #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicbarker
commented
Jan 2, 2025
bindings/odin/clay-odin/clay.odin
Outdated
| } else { | ||
| EnumBackingType :: u8 | ||
| } | ||
| EnumBackingType :: u8 |
There was a problem hiding this comment.
We should now have working u8 support on windows, but I will have to confirm this.
There was a problem hiding this comment.
Just tested and I misunderstood, still needs to be setup this way
There was a problem hiding this comment.
I thought that the enums would be u8 on windows as well...
There was a problem hiding this comment.
Yeah I was surprised and will investigate further, it's likely due to some combination of compiler and os that I'm using locally to generate the windows bindings. With the windows lib in the repo at the moment they are definitely 4 bytes, not 1 🤔
nicbarker
changed the title
nicbarker
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Odin bindings to match the latest changes in
clay.h, primarily adding the error handler toInitialize.