Introduce OCI Conformance Test Suite #82
Conversation
pmengelbert
force-pushed
the
initial-conformance-test
branch
from
927280b to
83480ec
Compare
|
nice! the CI failure looks like trailing whitespace all one commit. i know |
pmengelbert
force-pushed
the
initial-conformance-test
branch
from
83480ec to
4e237e9
Compare
|
@jdolitsky, @pmengelbert just some engineering process/hygiene? - https://github.com/golangci/golangci-lint |
pmengelbert
force-pushed
the
initial-conformance-test
branch
3 times, most recently
from
778901d to
303f076
Compare
@rchincha Thanks Ram, I'll look into it |
Added new conformance directory in the project root, with a number of test files written in Go. Tests can be compiled by running `go test -c` in the conformance directory and executing the created conformance.test file. In order for the tests to run, registry providers will need to set up certain environment variables with the root url, the namespace of a repository, and authentication information. Additionally, the OCI_DEBUG variable can be set to "true" for more detailed output. The tests create two report files: report.html and junit.xml. The html report is expandable if more detailed information is needed on failures. Related to opencontainers#24 Signed-off-by: Peter Engelbert <[email protected]>
pmengelbert
force-pushed
the
initial-conformance-test
branch
from
303f076 to
822d3a0
Compare
|
@jdolitsky @vbatts Thanks for the feedback -- I force-pushed an update with the requested changes. |
|
LGTM, especially for first pass. Would love to get merged so others are able to collaborate. |
|
i like it. |
|
LGTM |
|
LGTM! We should probably follow up with an issue that'll cover adding some basic gofmt lint checking to travis as well. |
|
@jzelinskie opened #83 to track CI stuff |
|
Talked about this on the (very short) call today a little, but as someone who's written ad-hoc registry clients in several languages (including several in Bash), what impressed me most about this was how short and readable all of these tests are. I'm not a maintainer on this repo (so can't help with the merge), but I love how they read so closely to how the spec does and I feel like I can clearly tell what each one is testing. 👍 ❤️ |
|
Wohoooo! |
Added new conformance directory in the project root, with a number of
test files written in Go. Tests can be compiled by running
go test -cin the conformance directory and executing the created conformance.test
file.
In order for the tests to run, registry providers will need to set up
certain environment variables with the root url, the namespace of a
repository, and authentication information. Additionally, the OCI_DEBUG
variable can be set to "true" for more detailed output.
The tests create two report files: report.html and junit.xml. The html
report is expandable if more detailed information is needed on failures.
Related to #24