Add CAP prefix for capabilities #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LK4D4 @crosbymichael @dqminh ping |
|
It's sorta breaking change for libcontainer :) Also capability library using words without |
|
@LK4D4 One option is to allow it in the config but strip it out while passing to libcontainer for now. |
|
Or maybe we can accept both. Detect if the old caps are started with |
|
LGTM |
Signed-off-by: Mrunal Patel <[email protected]>
Signed-off-by: Mrunal Patel <[email protected]>
|
Rebased @LK4D4 ping. |
|
If we merge this, we will still require a compatibility layer in docker to add |
|
@dqminh Yes, but I think that should be okay given all the other changes that we have made. @crosbymichael can correct me. |
|
LGTM |
1 similar comment
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Example lists "root' but text mentions "bundlePath"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See opencontainers/runtime-spec#160
Signed-off-by: Mrunal Patel [email protected]