Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcontainer/configs: add missing type for hooknames #2885

Merged
merged 1 commit into from
Apr 6, 2021
Merged

libcontainer/configs: add missing type for hooknames #2885

merged 1 commit into from
Apr 6, 2021

Conversation

thaJeztah
Copy link
Member

Commit ccdd757 (#2229) introduced the HookName type for hooks, but only set this type on the Prestart const, but not for the other hooks.

@thaJeztah
libcontainer/configs: add missing type for hooknames
4126b80 
Commit ccdd757 introduced the HookName type
for hooks, but only set this type on the Prestart const, but not for the
other hooks.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

@AkihiroSuda @kolyshkin @RenaudWasTaken ptal

@thaJeztah
Copy link
Member Author

Failure on CentOS looks like a flaky;

=== RUN   TestSystemdFreeze
    utils_test.go:86: exec_test.go:539: unexpected error: unable to freeze
        
--- FAIL: TestSystemdFreeze (4.45s)

@thaJeztah thaJeztah closed this Apr 2, 2021
@thaJeztah thaJeztah reopened this Apr 2, 2021
@RenaudWasTaken
Copy link
Contributor

Lgtm!

@kolyshkin
Copy link
Contributor 

utils_test.go:86: exec_test.go:539: unexpected error: unable to freeze

Dang! I though it was (practically) workarounded it by #2791 -- alas we did not. Funny thing is, my test setup included all sorts of interruptions to mess up with the freezing, and in this test nothing like that is happening, and yet the kernel is hiccuping...

kolyshkin
kolyshkin approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit d8a5f60 into opencontainers:master Apr 6, 2021
@thaJeztah thaJeztah deleted the config_missing_type branch April 6, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
easy-to-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @RenaudWasTaken @kolyshkin @AkihiroSuda