Add State status constants to spec-go #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
May 20, 2020
RenaudWasTaken
force-pushed
the
state-const
branch
2 times, most recently
from
3dbe02e to
3e7de59
Compare
|
LGTM |
thaJeztah
reviewed
Jul 1, 2020
|
ping @RenaudWasTaken could you have a look at #1046 (comment) ? edit: argh wrong name |
|
Sorry looking at it now! |
Signed-off-by: Renaud Gaubert <[email protected]>
Co-authored-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Renaud Gaubert <[email protected]>
RenaudWasTaken
force-pushed
the
state-const
branch
from
e3f5e08 to
66ad83f
Compare
|
@thaJeztah applied! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The State definition defines 4 constants for the status field that are not present in the specs-go
This PR adds them to the state.go file to make it available to runc.
/cc @cyphar @mrunalp @mikebrow
Signed-off-by: Renaud Gaubert [email protected]