-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: add cpu idle #1145
schema: add cpu idle #1145
Conversation
commit 9d363b3 added the feature but didn't update the json schema file. Signed-off-by: Giuseppe Scrivano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah. I wish there was a CI to block on missing schema coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need any changes for #1146, right?
I think we should be fine. #1146 is just a fix for the Go library to make clear when the value was specified in the configuration. In the example we have in "cpu": {
"shares": 1024,
"quota": 1000000,
"period": 500000,
"realtimeRuntime": 950000,
"realtimePeriod": 1000000,
"cpus": "2-3",
"idle": 1,
"mems": "0-7"
},
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
commit 9d363b3 added the feature but
didn't update the json schema file.
Signed-off-by: Giuseppe Scrivano [email protected]