Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.2.1 #1278

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Release v1.2.1 #1278

merged 2 commits into from
Feb 27, 2025
+30 −1

Conversation

kiashok
Copy link
Contributor

@kiashok kiashok commented Feb 25, 2025 •
edited by cyphar
Loading

Changes with v1.2.1:

Previous release: #1242

Additions:

* zos updates (#1273)
* Add support for windows CPU affinity (#1258)
* specs-go: sync SCMP_ARCH_* constants with libseccomp main (#1229)
* Add CPU affinity to executed processes (#1253)
* config-linux: describe the format of cpus and mems (#1253)

Minor fixes:

Documentation, CI & Governance:

* Fix description of errnoRet in Seccomp (#1277)
* config-linux: update for libseccomp v2.6.0 (#1276)
* Correct `prestart` hook description in summary (#1275)
* ci: Add a github actions workflow for lint (#1257)
* update http links to https (#1269)
* doc: fix the invalid hyperlink naming-a-volume (#1268)
* ci: remove redundunt actions (#1256)
* chore: format JSON file `make -C schema fmt` (#1255)
* config: simplify final CPU affinity rule (#1261)
* CODEOWNERS: remove vbatts (#1248)
* MAINTAINERS: move vbatts to EMERITUS (#1248)
* Update golangci-lint to v1.56.1 in CI (#1245)
* Add Go v1.21 and v1.22 to GitHub Actions CI matrix (#1245)
* Update GitHub Actions packages to resolve warnings in CI (#1244)

This release requires a two-thirds majority maintainers vote (8 of 11):

@kiashok kiashok changed the title Add release notes for v1.2.1 Release for v1.2.1 Feb 25, 2025
@kiashok kiashok changed the title Release for v1.2.1 Release v1.2.1 Feb 25, 2025
@kiashok
Copy link
Contributor Author

kiashok commented Feb 25, 2025

@AkihiroSuda I have followed release process here https://github.com/opencontainers/runtime-spec/blob/main/RELEASES.md and sent email and posted on the google group channel as well. My message there send "pending approval". Could you please help look into this? Thanks.

@kiashok
Copy link
Contributor Author

kiashok commented Feb 25, 2025

cc @jsturtevant

kolyshkin
kolyshkin reviewed Feb 25, 2025
View reviewed changes
kolyshkin
kolyshkin reviewed Feb 25, 2025
View reviewed changes
kolyshkin
kolyshkin reviewed Feb 25, 2025
View reviewed changes
kolyshkin
kolyshkin requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, mostly minor

@kiashok
Release v1.2.1
524fc0e 
Signed-off-by: Kirtana Ashok <[email protected]>
@kiashok
Add back +dev
95a651f 
Signed-off-by: Kirtana Ashok <[email protected]>
@kiashok
Copy link
Contributor Author

kiashok commented Feb 25, 2025

Left a few comments, mostly minor

Addressed them.

@AkihiroSuda AkihiroSuda added this to the vNext (tentative) milestone Feb 25, 2025
@thaJeztah
Copy link
Member

Saw #1274 (comment) suggested it we skip the other PR, it would be v1.2.1, but given that there are new additions (eg #1258) would v1.3.0 be more accurate?

@AkihiroSuda
Copy link
Member

Saw #1274 (comment) suggested it we skip the other PR, it would be v1.2.1, but given that there are new additions (eg #1258) would v1.3.0 be more accurate?

Either is fine to me

kolyshkin
kolyshkin approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link
Contributor

@opencontainers/runtime-spec-maintainers PTAL (I very much hope we can make this release this week).

@kolyshkin
Copy link
Contributor

@opencontainers/runtime-spec-maintainers PTAL (I very much hope we can make this release this week).

Mostly because we're about to release runc 1.3-rc1 soon and we'd like to have this one in.

mrunalp
mrunalp approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyphar
cyphar approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hqhq
hqhq approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@hqhq hqhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utam0k
utam0k approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giuseppe
giuseppe approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiashok
Copy link
Contributor Author

kiashok commented Feb 26, 2025

@thaJeztah would you be able to take a look when you have a chance please? Thanks!

@cyphar
Copy link
Member

cyphar commented Feb 27, 2025 •
edited
Loading

We have consensus already, I'll prepare the release artefacts and do the merge...

Oops, we have 11 maintainers not 10. My bad, I miscounted.

@kiashok
Copy link
Contributor Author

kiashok commented Feb 27, 2025

@tianon would you be able to take a look at this PR when you have a chance? Thanks!

@tianon tianon merged commit f6144db into opencontainers:main Feb 27, 2025
4 checks passed
@tianon
Copy link
Member

tianon commented Feb 27, 2025

Hah, I don't remember hitting merge here 🤦

Can someone do the tagging dance? (If not I'll get to it eventually)

@tianon
Copy link
Member

tianon commented Feb 27, 2025

Ah perhaps I jumped the gun completely and we need one more approval? 🤦

Golly, sorry for the mess. I'm happy to clean it up with a revert if we've got a maintainer left to vote who wants to reject, but also please speak up because I think this is pretty unobjectionable as-is. 👍

@cyphar
Copy link
Member

cyphar commented Feb 27, 2025 •
edited
Loading

@tianon No, with your approval we're all good. I've already got the tag ready, I'll push the release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@giuseppe giuseppe giuseppe approved these changes

@tianon tianon tianon approved these changes

@cyphar cyphar cyphar approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@hqhq hqhq hqhq approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@utam0k utam0k utam0k approved these changes

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@dqminh dqminh Awaiting requested review from dqminh dqminh is a code owner

@thaJeztah thaJeztah Awaiting requested review from thaJeztah thaJeztah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
10 participants
@kiashok @thaJeztah @AkihiroSuda @kolyshkin @cyphar @tianon @mrunalp @giuseppe @hqhq @utam0k