Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: fix missing ) #603

Merged
merged 1 commit into from
Oct 29, 2016
Merged

typo: fix missing ) #603

merged 1 commit into from
Oct 29, 2016

Conversation

coolljt0725
Copy link
Member

Signed-off-by: Lei Jitang [email protected]

@@ -49,7 +49,7 @@ The lifecycle describes the timeline of events that happen from when a container
1. OCI compliant runtime's [`create`](runtime.md#create) command is invoked with a reference to the location of the bundle and a unique identifier.
2. The container's runtime environment MUST be created according to the configuration in [`config.json`](config.md).
If the runtime is unable to create the environment specified in the [`config.json`](config.md), it MUST generate an error.
While the resources requested in the [`config.json`](config.md) MUST be created, the user-specified code (from [`process`](config.md#process-configuration) MUST NOT be run at this time.
While the resources requested in the [`config.json`](config.md) MUST be created, the user-specified code (from [`process`](config.md#process-configuration)) MUST NOT be run at this time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also fixed in #466 and #579. It would be nice if we could land at least one of those three PRs ;).

Signed-off-by: Lei Jitang <[email protected]>
@crosbymichael
Copy link
Member

crosbymichael commented Oct 28, 2016

LGTM

Approved with PullApprove

@hqhq
Copy link
Contributor

hqhq commented Oct 29, 2016

@wking I don't think we can get a quick consensus in #466 , and I don't the major fix in #579 is needed, so I'll merge this instead, thanks.

LGTM

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants