*: update link to v1.0.0 #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite this not being a valid link, until this spec has its v1.0.0 release, this URL ought to be accurate for once the this spec is tagged v1.0.0 Signed-off-by: Vincent Batts <[email protected]>
|
LGTM |
|
Do we embed version numbers elsewhere that could/should be updated at the same time? |
|
ala runtime-spec/specs-go/version.go Line 14 in 31c6569 |
|
@tianon that version gets updated with the PR put up for a version vote. |
|
Ok, fair enough!
|
|
@opencontainers/runtime-spec-maintainers PTAL before the vote is posted (today) |
|
LOKTM |
|
LGTM |
|
@vbatts did you want this merged or no? I was confused. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite this not being a valid link, until this spec has its v1.0.0
release, this URL ought to be accurate for once the this spec is tagged
v1.0.0
Part of #726
Signed-off-by: Vincent Batts [email protected]