Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't overwrite hook which has a same path #571

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

liangchenye
Copy link
Member

Signed-off-by: Liang Chenye [email protected]

@liangchenye
Copy link
Member Author

The issue is found in #569.

For history reason, we add a hook and add hook env separately, so the 'path' is the unique ID to add env correctly. Now we are adding a full hook with json format, so we don't need to have this limitation.
Also, in the spec, it is OK to have hooks with the same 'path'.

@liangchenye
Copy link
Member Author

PTAL @q384566678 @Mashimiao

@zhouhao3
Copy link

zhouhao3 commented Feb 7, 2018

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit ed3bcb2 into opencontainers:master Feb 7, 2018
@liangchenye liangchenye deleted the release branch February 28, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants