Modify the capabilities constants to match header files like other constants #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| inside the container. Valid values are the string after `CAP_` for capabilities defined | ||
| in [the man page](http://man7.org/linux/man-pages/man7/capabilities.7.html) | ||
| Capabilities is an array that specifies Linux capabilities that can be provided to the process inside the container. | ||
| Valid values are the strings for capabilities defined in [the man page](http://man7.org/linux/man-pages/man7/capabilities.7.html) |
There was a problem hiding this comment.
Maybe add (e.g. CAP_SYS_ADMIN), because those aren't strings in man.
There was a problem hiding this comment.
I modified the example json.
|
LGTM |
|
Why require the leading CAP_? Isn't that already clear from the
context (linux.capabilities)?
|
*.md: markdown formatting
|
to-may-to to-mah-to, is there a strong argument one way or the other? |
…nstants Signed-off-by: Mrunal Patel <[email protected]>
|
@philips Thinking it might be better to explicit in these cases and just match the values defined in the header files at the expense of typing few more characters. Rebased. |
|
LGTM |
|
lgtm |
vbatts
added a commit
that referenced
this pull request
Sep 9, 2015
Modify the capabilities constants to match header files like other constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mrunal Patel [email protected]