Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack/repack: save the --from argument #14

Closed
cyphar opened this issue Nov 6, 2016 · 1 comment
Closed

unpack/repack: save the --from argument #14

cyphar opened this issue Nov 6, 2016 · 1 comment
Labels
Milestone

Comments

@cyphar
Copy link
Member

cyphar commented Nov 6, 2016

When we do an umoci unpack we currently only keep track of the manifest hash that we extracted. We should also save (in umoci.state or something) the name of the reference that we dereferenced in order to get the extracted rootfs. This will allow us to remove the tedious --from argument in umoci repack.

The only real question to ask is whether we should make it possible for someone to forcefully create a rootfs that we cannot be sure is valid (namely specify --from and --mtree manually).

@cyphar cyphar added this to the 0.0.0 milestone Nov 6, 2016
@cyphar
Copy link
Member Author

cyphar commented Dec 6, 2016

This is being worked on in https://github.com/cyphar/umoci/tree/store-unpack-arguments.

cyphar added a commit that referenced this issue Dec 6, 2016
Implements #14
Signed-off-by: Aleksa Sarai <[email protected]>
@cyphar cyphar closed this as completed Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant