layer: always set bundle to 0700 on creation #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This protects against attacks where an unsafe image is extracted into a location where an unprivileged user could potentially access unsafe setuid binaries (or unsafe inodes). This protection is very easy to disable by a user of umoci, but the intention is to protect against lowest-common-denominator attacks. This is a slightly breaking change, but as it is a security issue (which was previously documented) we have made the change anyway. Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
rootfs-inode-creation-safe
branch
from
4e18873 to
04424ef
Compare
|
I really should've done this earlier. I was worried about breaking the usecase of a shared rootfs, which in retrospect wasn't a good idea. /cc @hallyn |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protects against attacks where an unsafe image is extracted into a
location where an unprivileged user could potentially access unsafe
setuid binaries (or unsafe inodes). This protection is very easy to
disable by a user of umoci, but the intention is to protect against
lowest-common-denominator attacks.
This is a slightly breaking change, but as it is a security issue (which
was previously documented) we have made the change anyway.
Fixes #181
Signed-off-by: Aleksa Sarai [email protected]