oci: tar extract: remove non-dir targets on unpack #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
tar-extract-create-eperm
branch
from
5dc51e9 to
18b7194
Compare
cyphar
force-pushed
the
tar-extract-create-eperm
branch
from
18b7194 to
ad4fbe5
Compare
|
Hi -- I tested this on a fedora box and it fixes the issue. LGTM. |
In order to work around cases where we are replacing a file we don't have write access to in unprivileged mode (as well as to clarify the hardlink semantics of unpacking), always remove the target path (unless it's a directory) before unpacking over it. As we always re-apply metadata this should not cause any issues. Signed-off-by: Aleksa Sarai <[email protected]>
This is to ensure we don't regress on file clobbering when we don't have write access to the target file. Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
tar-extract-create-eperm
branch
from
ad4fbe5 to
ff14ef1
Compare
|
LGTM. I will do a |
|
@lukasheinrich I have cut a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work around cases where we are replacing a file we don't
have write access to in unprivileged mode (as well as to clarify the
hardlink semantics of unpacking), always remove the target path (unless
it's a directory) before unpacking over it. As we always re-apply
metadata this should not cause any issues.
Fixes #222
Signed-off-by: Aleksa Sarai [email protected]