oci: casext: extend scope of valid reference names #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
extend-valid-refname-scope
branch
from
dd6308b to
129f97c
Compare
jonboulle
reviewed
Mar 23, 2018
oci/casext/refname.go
Outdated
| // IsValidReferenceName returns whether the provided annotation value for | ||
| // "org.opencontainers.image.ref.name" is actually valid according to the | ||
| // OCI specification. This only matches against the MUST requirement, not the | ||
| // SHOULD requirement. The EBNF defined in the speciifcation is: |
cyphar
force-pushed
the
extend-valid-refname-scope
branch
from
129f97c to
0e56922
Compare
Previously we only supported a very limited subset of reference names
(as per the specification), but the restrictions have been expanded to
allow for any reference of the form
refname ::= component ("/" component)*
component ::= alphanum (separator alphanum)*
alphanum ::= [A-Za-z0-9]+
separator ::= [-._:@+] | "--"
Add support for this newly expanded set of reference names. In addition,
refactor the checks for whether a reference name is valid.
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
extend-valid-refname-scope
branch
from
0e56922 to
9d12668
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only supported a very limited subset of reference names
(as per the specification), but the restrictions have been expanded to
allow for any reference of the form
Add support for this newly expanded set of reference names. In addition,
refactor the checks for whether a reference name is valid.
Signed-off-by: Aleksa Sarai [email protected]