Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws only public subnets coverage #62226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

aws only public subnets coverage #62226

wants to merge 1 commit into from
+446 −31

Conversation

jianlinliu
Copy link
Contributor

@jianlinliu jianlinliu commented Feb 28, 2025 •
edited
Loading

Installer supports OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY, once it enabled, that means the vpc would be NAT-less, installer would only depends on public subnets. The feature can help save budget for nat gateway cost.

@openshift-ci openshift-ci bot requested review from asood-rh and gpei February 28, 2025 11:54
@openshift-ci-robot
Copy link
Contributor

@jianlinliu, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo656459136/ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/byo-subnets/deprovision/cucushift-installer-rehearse-aws-ipi-private-deprovision-chain.yaml has incorrect prefix. Prefix should be cucushift-installer-rehearse-aws-ipi-byo-subnets-deprovision
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu jianlinliu force-pushed the publicsubnets branch 3 times, most recently from b237ec8 to ba8158a Compare February 28, 2025 12:40
@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.19-aws-ipi-shared-phz-sts-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-workers-marketplace-public-subnets-mini-perm-f7

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

rehearse testing jobs get passed.

When OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY enabled, job is here.
When OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY disabled (by default), job is here.

cc @yunjiang29 to review.

@jianlinliu jianlinliu force-pushed the publicsubnets branch 2 times, most recently from 2ec5a2f to dcd3744 Compare March 3, 2025 08:57
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianlinliu
Once this PR has been reviewed and has the lgtm label, please assign asood-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 3, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 4, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianlinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-api-provider-powervs-main-okd-scos-e2e-aws-ovn openshift/machine-api-provider-powervs presubmit Registry content changed
pull-ci-openshift-machine-api-provider-powervs-release-4.18-okd-scos-e2e-aws-ovn openshift/machine-api-provider-powervs presubmit Registry content changed
pull-ci-openshift-special-resource-operator-release-4.8-e2e-aws openshift/special-resource-operator presubmit Registry content changed
pull-ci-openshift-special-resource-operator-release-4.7-e2e-aws openshift/special-resource-operator presubmit Registry content changed
pull-ci-openshift-grafana-tempo-operator-main-tempo-product-ocp-4.17-stage-tempo-stage-tests openshift/grafana-tempo-operator presubmit Registry content changed
pull-ci-openshift-grafana-tempo-operator-main-tempo-product-ocp-4.17-stage-tempo-stage-tests-fips openshift/grafana-tempo-operator presubmit Registry content changed
pull-ci-openshift-grafana-tempo-operator-main-tempo-product-ocp-4.16-stage-tempo-stage-tests openshift/grafana-tempo-operator presubmit Registry content changed
pull-ci-openshift-grafana-tempo-operator-main-tempo-product-ocp-4.14-arm-stage-tempo-stage-tests openshift/grafana-tempo-operator presubmit Registry content changed
pull-ci-openshift-grafana-tempo-operator-main-tempo-product-ocp-4.12-stage-tempo-stage-tests openshift/grafana-tempo-operator presubmit Registry content changed
pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.16-amd64-aws-ipi-shared-vpc-phz-sts-tempo-e2e-tests openshift/grafana-tempo-operator presubmit Registry content changed
pull-ci-openshift-grafana-tempo-operator-main-tempo-product-ocp-4.18-stage-tempo-stage-tests openshift/grafana-tempo-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-master-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.20-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.19-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.18-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.17-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.16-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.15-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.14-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.13-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.12-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.11-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.10-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.9-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.8-e2e-aws-operator openshift/cluster-openshift-apiserver-operator presubmit Registry content changed

A total of 9634 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: job(s): periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 either don't exist or were not found to be affected, and cannot be rehearsed

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-mini-perm-arm-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@jianlinliu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 b994771 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-workers-marketplace-public-subnets-mini-perm-f7 ff69bee link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-workers-marketplace-public-subnets-mini-perm-f7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asood-rh asood-rh Awaiting requested review from asood-rh

@gpei gpei Awaiting requested review from gpei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianlinliu @openshift-ci-robot