Update the toggle_scheduling_mode to wait until the switch happens. #18132
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dombesz
force-pushed
the
fix-flaky-spec
branch
2 times, most recently
from
d350cd8 to
e4121fb
Compare
This is required to prevent submitting the datepicker form too quickly, before the toggle happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
What are you trying to accomplish?
Prevent submitting the datepicker form too quickly, before the toggle happens.
What approach did you choose and why?
This expectation waits for the turbo request to complete and prevent submitting the form too early.
Additionally another bug is fixed here which caused the calendar turbo frame rendering to bloat the dom by not replacing the correct elements. To reproduce the original issue, just switch between manual an automatic mode a few times. Every time the re-render happens, a new turbo frame is added inside the existing one.
Screenshot of the error
Merge checklist