Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Fixing VR height #4005

Merged
merged 13 commits into from
Feb 27, 2025
Merged

Button: Fixing VR height #4005

merged 13 commits into from
Feb 27, 2025

Conversation

gabrielpereirapinheiro
Copy link
Contributor

Before:
SM
Screenshot 2025-02-20 at 08 25 17
MD
Screenshot 2025-02-20 at 08 24 59
LG
Screenshot 2025-02-20 at 08 29 13

After:
SM
Screenshot 2025-02-20 at 08 26 16
MD
Screenshot 2025-02-20 at 08 25 58
LG
Screenshot 2025-02-20 at 08 25 46

@gabrielpereirapinheiro gabrielpereirapinheiro requested a review from a team as a code owner February 20, 2025 16:29
@netlify Netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e96812
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/67c0af19ce7b6200084213ab
😎 Deploy Preview https://deploy-preview-4005--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlbertCarreras
Copy link
Contributor

Button works but now ButtonLink seems broken
Screenshot by Dropbox Capture

AlbertCarreras
AlbertCarreras requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment below

gabrielpereirapinheiro
gabrielpereirapinheiro commented Feb 24, 2025
View reviewed changes
Copy link
Contributor Author

@gabrielpereirapinheiro gabrielpereirapinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button link fixed

AlbertCarreras
AlbertCarreras requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot by Dropbox Capture

@AlbertCarreras
Copy link
Contributor

Let's put the examples back, however let's remove px size references cos they are outdated.

@AlbertCarreras AlbertCarreras self-requested a review February 25, 2025 16:14
AlbertCarreras
AlbertCarreras requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put the examples back, however let's remove px size references cos they are outdated.

@AlbertCarreras AlbertCarreras merged commit a63d1cd into pinterest:master Feb 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertCarreras AlbertCarreras AlbertCarreras approved these changes

Assignees
No one assigned
Labels
minor release Minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielpereirapinheiro @AlbertCarreras