Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add aarch64 linux runner #15077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Jan 17, 2025

What does this PR try to resolve?

Linux arm64 hosted runners is in public preview.
Enable and see if is is something we can have now.

https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

How should we test and review this PR?

aarch64-unknown-linux-gnu is a tier-1 target platform.
It is better to have this in Cargo's CI.

Cross-compilation tests are disabled temporarily on this platform.

Additional information

https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Free.20Linux.20ARM64.20runners.20on.20GHA.20now.20in.20beta

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2025
@weihanglo weihanglo changed the title chore: add aarch64 linux runner [WIP] chore: add aarch64 linux runner Jan 17, 2025
@@ -155,6 +163,9 @@ jobs:
- uses: actions/checkout@v4
- name: Dump Environment
run: ci/dump-environment.sh
# workaround for https://github.com/actions/partner-runner-images/issues/26
Copy link
Contributor

@arlosi arlosi Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the linked issue, it's available/fixed now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ran the tests and everything passed except cross compile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current arm machine sometimes throws a random free() allocation error. I lost the exact build failure, but feel like it is not really stable yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigation into compilation problems are currently being investigated in rust-lang/rust#135867.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it https://github.com/weihanglo/cargo/actions/runs/12939625507/job/36092284988#step:13:48.

  free(): invalid next size (fast)

It doesn't seem to be a compilation error though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed. Should we make it into our CI pipeline?

Linux arm64 hosted runners is in public preview.
Enable and see if is is something we can have now.

setting `target.linker` is required for cross-compilation
on ARM64, so disable cross compilation tests for it.

https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
@weihanglo weihanglo changed the title [WIP] chore: add aarch64 linux runner chore: add aarch64 linux runner Feb 23, 2025
@weihanglo weihanglo marked this pull request as ready for review February 23, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants