Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: avoid checks leftovers #686

Merged
merged 2 commits into from
Mar 2, 2025
Merged

SCons: avoid checks leftovers #686

merged 2 commits into from
Mar 2, 2025

Conversation

vassilit
Copy link
Collaborator

@vassilit vassilit commented Mar 1, 2025

Closes: #685

echo "" | cc -xc - -c generates a '-.o' leftover (gcc/clang).

Copy link
Collaborator

@fermino fermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I will merge it as soon as it passes CI.

@fermino
Copy link
Collaborator

fermino commented Mar 1, 2025

@vassilit would you mind changing https://github.com/sahib/rmlint/blob/master/.github/workflows/build-and-test.yml#L12 to ubuntu-22.04? ubuntu-latest is now 24.04 and there has python imp's module seems to have been removed.

This change should eventually be caught by #677, but for now it'd be nice to have this merged.
If you add it in a different commit I will fast-forward master so the changes are not mixed.

Thanks again! :)

Related issue: actions/runner-images#10636

Edit: wrong link.

@vassilit vassilit merged commit 50bd39e into sahib:master Mar 2, 2025
1 check passed
@vassilit
Copy link
Collaborator Author

vassilit commented Mar 2, 2025

I merged this PR, because this was marked as approved by you, but doing so I voided your PR #688, without intending to do so. Sorry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking for C11 generates an empty '-.o' file
2 participants