Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple semver tags to docker releases #2725

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RoboMagus
Copy link

Change to GH Workflow that publishes Docker images.

This PR will add additional tags to each release (Rationale). E.g. when releasing v2.13.1, additional tags v2 and v2.13 are added. These allow users to pin their preferred main and/or minor version whilst still pulling in patch releases when they are released.

@fiftin
Copy link
Collaborator

fiftin commented Feb 3, 2025

Looks good. But let's remove type=semver,pattern=v{{major}} for now. The major version unchanged since 2016. And I have no plan to change it :)

@RoboMagus
Copy link
Author

But let's remove type=semver,pattern=v{{major}} for now. The major version unchanged since 2016. And I have no plan to change it :)

Yeah makes sense, but that is sort of the point though. Should the time arise that the major version does get a bump because of a big breaking change having the option to stay up to date with minor versions automatically but hold of on an update that causes said breaking change.
Such issues arose recently with e.g. Zigbee2MQTT that upgraded to v2.x after about 6 years of minor releases on v1.x

I'll be happy to remove the major version tag if you're certain this is not something you want, but as a precaution (i.e. just anything between sticking to latest and manually updating for every minor tag) it has a lot of added value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants