-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add grafana dashboard to helm chart #388
Conversation
Signed-off-by: Devin Buhl <[email protected]>
Signed-off-by: Devin Buhl <[email protected]>
Signed-off-by: Devin Buhl <[email protected]>
Signed-off-by: Devin Buhl <[email protected]>
Signed-off-by: Devin Buhl <[email protected]>
@onedr0p I need to check what licensing implications come with including a Grafana dashboard in this repo. I am aware of other projects removing their dashboards after the license change in Grafana occurred. |
Interesting, I don't see that being an issue here though... |
Signed-off-by: Devin Buhl <[email protected]>
Signed-off-by: Devin Buhl <[email protected]>
@phillebaba were you able to find out anything? I am guessing you are not the one that released the dashboard on Grafana's dashboard site? https://grafana.com/grafana/dashboards/18089-spegel-stateless-cluster-local-oci-registry-mirror/ |
No i have not received answers for my inquiries yet. I am neither the person who created the dashboard published there. I will try to reach out to the person and see if we can get an ok for licensing reasons. We need to also verify that this method will work when packaging the chart into an OCI artifact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long time @onedr0p.
Things look good, I just verified that this would also work when packaged as an OCI artifact. Thanks for the work 🌹
@mrclrchtr could you open an issue to track this? |
Yes, sure: #509 |
feat: add grafana dashboard to helm chart
Fixes #387