Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grafana dashboard to helm chart #388

Merged
merged 16 commits into from
Apr 25, 2024

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Mar 17, 2024

Fixes #387

@phillebaba
Copy link
Member

@onedr0p I need to check what licensing implications come with including a Grafana dashboard in this repo. I am aware of other projects removing their dashboards after the license change in Grafana occurred.

@onedr0p
Copy link
Contributor Author

onedr0p commented Mar 22, 2024

I am aware of other projects removing their dashboards after the license change in Grafana occurred.

Interesting, I don't see that being an issue here though...

@onedr0p
Copy link
Contributor Author

onedr0p commented Apr 2, 2024

@phillebaba were you able to find out anything? I am guessing you are not the one that released the dashboard on Grafana's dashboard site? https://grafana.com/grafana/dashboards/18089-spegel-stateless-cluster-local-oci-registry-mirror/

@phillebaba
Copy link
Member

No i have not received answers for my inquiries yet. I am neither the person who created the dashboard published there. I will try to reach out to the person and see if we can get an ok for licensing reasons.

We need to also verify that this method will work when packaging the chart into an OCI artifact.

Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long time @onedr0p.

Things look good, I just verified that this would also work when packaged as an OCI artifact. Thanks for the work 🌹

@phillebaba phillebaba merged commit 6d4b345 into spegel-org:main Apr 25, 2024
6 checks passed
@mrclrchtr
Copy link

Hi, thanks for adding this.

Unfortunately I get the following message in Grafana when I turn it on:

Datasource ${DS_PROMETHEUS} was not found

image

What am I doing wrong?

I'm using kube-prometheus-stack.

@onedr0p onedr0p deleted the grafana-dashboard branch June 10, 2024 13:02
@onedr0p
Copy link
Contributor Author

onedr0p commented Jun 10, 2024

@mrclrchtr could you open an issue to track this?

@mrclrchtr
Copy link

Yes, sure: #509

t1mt pushed a commit to t1mt/spegel that referenced this pull request Sep 3, 2024
feat: add grafana dashboard to helm chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Grafana dashboards as option to enable in Helm charts
3 participants