fix(charts): remove metrics label from bootstrap svc #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejoeejoee
changed the title
thejoeejoee
force-pushed
the
fix-helm-service-component
branch
from
e70e99b to
11755ff
Compare
thejoeejoee
changed the title
phillebaba
force-pushed
the
fix-helm-service-component
branch
from
11755ff to
4acc086
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bootstrap service has
app.kubernetes.io/component: metricslabel, which wrongly leads to selecting the service (e.g. from ServiceMonitor).This PR drops the wrongly placed label.