Remove p2p route table check on startup #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
changed the title
t1mt
pushed a commit
to t1mt/spegel
that referenced
this pull request
Sep 3, 2024
Remove p2p route table check on startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thinking originally was that the registry should not start until bootstrap had completed. This was implemented when the mirror configuration was not written until the registry had started. With the introduction of the node port service which forwards traffic to other nodes to handle the mirroring there is no real point of doing this. Especially because we have seen startup issues when a cluster is being created.
What will happen now is that if the routing table is not populated a 404 will be returned forcing Containerd to attempt the next option in the mirror list.
I have added a TODO to explore if its worth returning early if the routing table is empty.