support multiple default ippools #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
added
pr/release/feature-new
pr/ready-review
Icarus9913
requested review from
weizhoublue,
windsonsea,
Michelle951 and
Jeanine-tw
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
- Coverage 81.81% 81.26% -0.55%
==========================================
Files 49 49
Lines 5218 5194 -24
==========================================
- Hits 4269 4221 -48
- Misses 788 817 +29
+ Partials 161 156 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Icarus9913 <[email protected]>
Icarus9913
force-pushed
the
feat/wk/multiple-default-ippools
branch
from
8d263ad to
398b2c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past version, we only support one IPPool as default in IPv4/IPv6, now we set it free and multiple IPPools could be set as default.
Signed-off-by: Icarus9913 [email protected]