Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spiderpool IPAM has the ability to allocate IP addresses from an array of IPPools. If you use
ipam.spidernet.io/ippool
oripam.spidernet.io/ippools
annotation to specify IPPools or you use CNI configurationdefault_ipv4_ippool
to specify IPPools, the system would allocate IPs from these IPPools in order.For instance:
But once if you do not set any annotation or CNI configuration rules, the backend system will search all SpiderIPPool resources with "Spec.Default == true". In this case, the backend system can't control the sequence for the IPPool candidates array and may lead to #2042 .
Consequently, I optimize the backend logic and sort the IPPool candidates sequence with the filter rules.
And it's suitable for all IPPool allocation rules.
For example:
or
Signed-off-by: Icarus9913 [email protected]
What this PR does / why we need it:
new feature
Which issue(s) this PR fixes:
close #2042