Update GOMAXPROCS configuration #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lou-lan
commented
Sep 9, 2024
lou-lan
commented
- Replace manual GOMAXPROCS setting with maxprocs package for improved handling.
- Log a warning if setting GOMAXPROCS fails.
- Ensure min value is used when setting max procs from configuration.
- Replace manual GOMAXPROCS setting with maxprocs package for improved handling. - Log a warning if setting GOMAXPROCS fails. - Ensure min value is used when setting max procs from configuration. Signed-off-by: lou-lan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.8 #4040 +/- ##
=============================================
Coverage 81.49% 81.49%
=============================================
Files 49 49
Lines 4340 4340
=============================================
Hits 3537 3537
Misses 641 641
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
approved these changes
Sep 10, 2024
weizhoublue
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.